-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect Home Section settings from web #1414
Conversation
Just curious, would this affect things such as the default sort order for Collections? The default on web is to show movies in a collection sorted by release date, but on Roku the default is alphabetical. Each collection can be individually changed to sort by release date, but that can take awhile to do depending on number of collections. Thanks! This issue is referenced in #391 |
@lakerssuperman That's a separate issue and would need to be address in a different part of the code. This PR's goal is to make the sections on Roku match the sections setup on the server settings - except for Roku adding a Favorites section to the bottom, which is not an option in the web settings. |
Roger Roger. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's my notes from testing. Still need to look at the code.
Is your plan to support everything in the web client -> user settings -> Home section?
If so, these are the items that didn't work based on my testing:
My Media (small)
looked the same asMy Media
- Duplicate section entries resulted in only the first entry being shown (I don't think this is an issue just mentioning it)
Default screen
does nothing for music, tvshow, and movie libraries (Live TV works)
Not as part of this PR. As you mentioned, the section
I had to deal with this directly in code. Roku simply will not show a duplicated row. Try as I might to make it work, it never worked. So for this PR, I use the 1st instance only.
That's outside the bounds of this PR. The goal is only to honor the home section selections and order. |
Now updates favorites, Live TV on now, and latest in library sections when returning to view. Code cleanup. Fire loaded beacon after 2 rows load.
Changes
Updates home view so the sections follow the settings from the web. This will causes the Roku home view to match the web home view except for Roku displaying the favorites row at the bottom, which is not an option on web.
There will be follow up PRs to allow users to set custom section settings on the Roku client. I separated them to limit scope for testing.
Issues
Fixes #1385